Code for people interested https://codeberg.org/rimu/pyfedi/src/branch/main/app/admin/routes.py#L373
I commented it out, rebuild the Docker containers and it works now 👍
You must log in or # to comment.
Sir a second hardcoded blacklist hit the fediverse
List of blocked words in community names:
shit piss fuck cunt cocksucker motherfucker tits memes piracy 196 greentext usauthoritarianism enoughmuskspam political_weirdos 4chanSeems like one of the PieFed devs has some opinions about the kind of content they dislike, and are unilaterally forcing that on every PieFed instance. I can somewhat understand filtering out curse words, but specific communities should not blocked by default, and definitely not hidden in a hardcoded list in the source code.
This isn’t the first time I’ve encountered an extremely pointed line of code in piefed meant to fuck over one person specifically. It’s very concerning now that it’s a pattern.
Hard-coded filters, here we go again.
https://github.com/LemmyNet/lemmy/issues/622Damn this should honestly be spread and talked about more. I don’t think many people know this is a thing?
Considering PieFed users won’t shut the fuck up about how much better and less politically opinionated it is, yeah we should probably shout this from the rooftops.
Reminds me of Brave browser users a bit
So if I started a piefed instance and wanted to host a 196 community I’d have to edit the list, but would every single other instance also have to or no?
Yes, every other instance would also refuse to federate unless they also changed their code. Because the blocklist is baked right into the code, so anyone just pulling and running it as-is will fail to federate.
They also put “memes” and “enoughmuskspam.”
The latter I guess could be used to stop Musk spam (since the community is literally nothing but Elon Musk news) but not allowing the word “memes” in a community name?
Utterly stupid.
But they do appear to be fans of Carlin based on the first 7 banned words.
There’s no racial slurs in there either. I might have assumed this was merely an example an operator is meant to edit themselves, but these are some weird ass choices for even that.
Well, it seems specifically 196 just got removed: https://codeberg.org/rimu/pyfedi/commit/b7a9ea0eea3a80f710e0b5b63cf0bbecde60f8bf
George Carlin would be amused.
They’re pretty explicit about what they don’t like when you sign up. That’s why I joined it
Each instance should be free to set their own rules. Individual instances blocking those communities is fine, but the PieFed devs hardcoding a blocklist that applies to all instances (especially one as opinionated and arbitrary as this) is absolutely not.
Side note: lmfao wtf is this Mickey Mouse block-quote-but-not-really bullshit?
Hardcoded blacklists are never a good idea.
That shit belongs in a config file.
What, why 196? Actually why any of these? I get 4chan and greentext sort of(?) but even ignoring the terrible programming practices here, this is really stupid.
Edit: actually almost makes me regret switching to Piefed
They just removed it from the list 15 minutes ago
Ah, that’s good to hear. I’m still sketched out by the hardcoded blacklist of terms though. I’m very much a person against the sort of free speech that hinders other’s freedom to live without discrimination but the filter still seems so arbitrary and entirely the response to the dev’s own vandettas and that just gives me bad vibes.
On top of that, hardcoding English language terms to block is bad programming on a number of levels. Why isn’t it a configurable list? The hardcoded values don’t contain any other language variants so you can still have those communities if you speak something other than English (or just add an extra couple characters or anything really)
I know the feeling (over here on .world)
Never meet your heroes
Never read the code of a project you respect
That is some nasty code.
Jesus that’s a lot of spaghetti code, and why are they hardcoding a bunch of terms? Is this just for a public facing site, or does every deployed instance effectively filter these out?
It’s hardcoded in the PieFed source code, so every instance does this by default unless you patch it like I did.
The combined swearwords + excluded communities list seems to appear at least 3 times in the codebase (not referenced, copied verbatim).
Let’s just say that it wouldn’t pass my code review if I saw this at work
The piefed.world instance has some of these edited out but I don’t think they all are.
Yeah. The list should be in the site config. Go ahead and include those as defaults to block, but allow sites to override that.
OP, are you saying that the federation is blocked on the OUTGOING side? Because then that just seems bass ackwards.
No, it’s incoming. When you first set up an instance you have to kickstart the federation process by adding communities to federate. The linked code excludes those specified communities from that. Once federated, they won’t be blocked AFAIK.
Well, like the Lemmy devs, I guess the PieFed devs have decided to plant a flag instead of making a neutral platform for federated communication.
The Lemmy devs don’t seem to hardcode those opinions into Lemmys source code.
They had one for a while, but removed it on pushback.
Dear God, that code! Why is it all in one file? The more I read it the worse it becomes!
Holy crud, you were not kidding. I got through a bit and was just like, “nah I ain’t reading this shit”.
Very glad I never got deeper into PieFed. Great post.
Huh, so thats why i havent seen greentexts in quite some time.
Holy shit, 2200 loc
goddamn, asshole, peepee, and poopoo are missing.
That’s interesting. I understand not wanting to fed some of those communities.
I definitely understand wanting to filter out obscenities, but I think the filtered communities should be a seperate configurable list.
As a mod of !fuckcars@lemmy.world, I’m kinda upset about the “filter out obscenities” part.
the cursewords are specifically referencing George Carlins 7 words you can’t say on air.
Is this the “shit piss fuck” list?
Yes, it starts with swear words, the names of some communities are also thrown in.
deleted by creator
